Thread: SystemObject show patch

Hi Dave.

The range of the system object doesn't seem to be appropriate.
Or, are there other reasons of anything?

Apply ptach if there are not some problems.
But, may not be completely clear in this.

Regards,
Hiroshi-Saito

Thanks, patch applied.

> -----Original Message-----
> From: Hiroshi Saito [mailto:saito@inetrt.skcapi.co.jp]
> Sent: 15 July 2003 06:37
> To: Andreas Pflug; Dave Page
> Cc: pgadmin-hackers@postgresql.org
> Subject: SystemObject show patch
>
>
> Hi Dave.
>
> The range of the system object doesn't seem to be
> appropriate. Or, are there other reasons of anything?
>
> Apply ptach if there are not some problems.
> But, may not be completely clear in this.
>
> Regards,
> Hiroshi-Saito
>
>

Dave Page wrote:

>Thanks, patch applied.
>
>

I'm just in the middle of applying them. While in general Hiroshi is
right, there are som bad implementations in it. Casting a pgCast to a
pgServer is a very bad idea...

Regards,
Andreas

> -----Original Message-----
> From: Andreas Pflug [mailto:pgadmin@pse-consulting.de]
> Sent: 15 July 2003 09:04
> To: Dave Page
> Cc: Hiroshi Saito; pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] SystemObject show patch
>
>
> Dave Page wrote:
>
> >Thanks, patch applied.
> >
> >
>
> I'm just in the middle of applying them. While in general Hiroshi is
> right, there are som bad implementations in it. Casting a pgCast to a
> pgServer is a very bad idea...

Eep, sorry, missed that. Need coffee...

Regards, Dave.

Hi Andreas.

From: "Andreas Pflug" <pgadmin@pse-consulting.de>
> Dave Page wrote:
(snip)
> I'm just in the middle of applying them. While in general Hiroshi is
> right, there are som bad implementations in it. Casting a pgCast to a
> pgServer is a very bad idea...

It was seen.
-----------------
bool GetSystemObject() const { return GetOid() <=
GetConnection()->GetLastSystemOID(); }
------------------
Indeed is good.
I'm study more...,Aiming at you.

Regards,
Hiroshi-Saito