Thread: Two fixes for pgadmin III...

Two fixes for pgadmin III...

From
"Yurgis Baykshtis"
Date:
Guys, I have a couple of fixes for you. More to come ;)

First is to fix the bug that prevents updating the functions.
Second is to fix the bug that prevents creating a new index.

RCS file: /disk1/cvsroot/pgadmin3/src/ui/dlgFunction.cpp,v
retrieving revision 1.7
diff -r1.7 dlgFunction.cpp
333,334c333,334
<         name = function->GetQuotedFullIdentifier();
<
---
>         name = function->GetQuotedFullIdentifier()
>                 + wxT("(") + function->GetArgTypes() +
wxT(")");



RCS file: /disk1/cvsroot/pgadmin3/src/ui/dlgIndex.cpp,v
retrieving revision 1.8
diff -r1.8 dlgIndex.cpp
242a243
>             sql += wxT("\n   ON ") + table->GetFullIdentifier();
244,245c245
<             sql += wxT("\n   ON ") + table->GetFullIdentifier()
<                 + wxT("(") + GetColumns()
---
>             sql += wxT("(") + GetColumns()



Re: Two fixes for pgadmin III...

From
"Dave Page"
Date:

> -----Original Message-----
> From: Yurgis Baykshtis [mailto:ybaykshtis@aurigin.com]
> Sent: 24 May 2003 01:24
> To: Andreas Pflug; Dave Page; pgadmin-hackers@postgresql.org
> Subject: Two fixes for pgadmin III...
>
>
> Guys, I have a couple of fixes for you. More to come ;)
>
> First is to fix the bug that prevents updating the functions.
> Second is to fix the bug that prevents creating a new index.

Thanks Yurgis,

I was just about to do these when I noticed Andreas has done it already.

Thanks for the fixes - any more you find are more than welcome!

Regards, Dave

Re: Two fixes for pgadmin III...

From
Andreas Pflug
Date:
Yurgis Baykshtis wrote:

>Guys, I have a couple of fixes for you. More to come ;)
>
>First is to fix the bug that prevents updating the functions.
>Second is to fix the bug that prevents creating a new index.
>
>
>
Thanks,

patches applied.

Im sure there are *plenty* of those problems still in pgadmin3.

Anybody who notices a sql syntax problem, please feel free to mention it
without further source investigation.

Regards,
Andreas