Re: Fixes and enhancements to JDBC driver (take 2) - Mailing list pgsql-patches

From Gunnar R|nning
Subject Re: Fixes and enhancements to JDBC driver (take 2)
Date
Msg-id x6bst5dl7g.fsf@thor.candleweb.no
Whole thread Raw
In response to Fixes and enhancements to JDBC driver (take 2)  (Richard Bullington-McGuire <rbulling@microstate.com>)
List pgsql-patches
Richard Bullington-McGuire <rbulling@microstate.com> writes:

> * A serious off-by-one error existed in both of the BytePoolDim classes in
> the org.postgresql.PG_Stream class. On a request for a byte pool for the
> maximum size, the old code would generate an
> ArrayIndexOutOfBoundsException. I fixed this by increasing the size of
> the array by one more than the maximum buffer size, and altering the
> supporting methods to initialize and clean up the expanded array.

This BytePoolDim code got other problems as well. I posted another
implementation of the same pooling idea back in October, but it never got
in to replace the current buggy code. As I wrote in pgsql-general earlier
today, I will look into creating a new patch with another pooling
implementation that should work a lot better.

regards,

    Gunnar

pgsql-patches by date:

Previous
From: Richard Bullington-McGuire
Date:
Subject: Re: Patch for JDBC timestamp problems
Next
From: Bruce Momjian
Date:
Subject: lcons -> makeList patch