Re: walreceiver is uninterruptible on win32 - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: walreceiver is uninterruptible on win32
Date
Msg-id v2o3f0b79eb1004042318u3aa4f546l8f2a14b01df07cb1@mail.gmail.com
Whole thread Raw
In response to Re: walreceiver is uninterruptible on win32  (Magnus Hagander <magnus@hagander.net>)
Responses Re: walreceiver is uninterruptible on win32  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
On Fri, Apr 2, 2010 at 11:11 PM, Magnus Hagander <magnus@hagander.net> wrote:
> More to the point, I'm not sure I like the creation of yet another DLL
> to deal with this. The reason this isn't just exported from the main
> backend is the same reason we created the libpqwalreceiver library I'm
> sure - bt that means we already have one.
>
> How about we just use this same source file, but compile and link it
> directly into both dblink and libpqwalreceiver? That'd leave us with
> one DLL less, making life easier.

ISTM that we cannot compile dblink using USE_PGXS=1, if that DLL doesn't
exist in the installation directory. No?

> As for the code itself, don't we need a CHECK_FOR_INTERRUPTS in there
> for it to be actually useful?

Yes. I'll add a CHECK_FOR_INTERRUPTS in the loop.

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


pgsql-hackers by date:

Previous
From: TAKATSUKA Haruka
Date:
Subject: contrib check fail at pgcrypto on Windows Server 2008 64bit 9.0dev (HEAD near alpha5)
Next
From: TAKATSUKA Haruka
Date:
Subject: contrib check fail at pgcrypto on Windows Server 2008 64bit 9.0dev (HEAD near alpha5)