Re: What has happened to pgxs? - Mailing list pgsql-hackers

From Thomas Hallgren
Subject Re: What has happened to pgxs?
Date
Msg-id thhal-00DsPBG9j8bQ9p3F40SRmxyzHRvYNly@mailblocks.com
Whole thread Raw
In response to Re: What has happened to pgxs?  (Thomas Hallgren <thhal@mailblocks.com>)
List pgsql-hackers
Sorry, that conclusion was wrong. What happens is:
1. I change the prefix in Makefile.global to say, 
C:/Progra~1/PostgreSQL/8.1-beta2 (this is  the default for the installer).
2. I compile.

That triggers the append of 'postgresql' on all directories since my 
install location *does not* contain the word 'postgres' nor 'pgsql'.

Regards,
Thomas Hallgren

Thomas Hallgren wrote:
> There's another issue with the Makefile.global.in that I feel should be 
> addressed here. The file contains a lot of entries like:
> 
> ifeq "$(findstring pgsql, $(pkgincludedir))" ""
> ifeq "$(findstring postgres, $(pkgincludedir))" ""
> override pkgincludedir := $(pkgincludedir)/postgresql
> endif
> endif
> 
> Guess what happens if the install-location in itself contains the string 
> postgres?
> A more correct way of doing it is probably to check if the directory in 
> question *ends with* pgsql or postgres rather then if it contains it.
> 
> Regards,
> Thomas Hallgren
> 
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
>       choose an index scan if your joining column's datatypes do not
>       match
> 




pgsql-hackers by date:

Previous
From: "Jim C. Nasby"
Date:
Subject: Re: PCTFree Results
Next
From: "Dave Page"
Date:
Subject: Re: pgxs and pginstaller