Postgres Pro
Downloads
Home   >   mailing lists

Re: MarkBufferDirty Assert held LW_EXCLUSIVE lock fail when ginFinishSplit - Mailing list pgsql-bugs

From feichanghong
Subject Re: MarkBufferDirty Assert held LW_EXCLUSIVE lock fail when ginFinishSplit
Date
Msg-id tencent_1A086A4AE9EF0919669DD11F8F26F41C4508@qq.com
Whole thread Raw
In response to Re: MarkBufferDirty Assert held LW_EXCLUSIVE lock fail when ginFinishSplit  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-bugs
Tree view
Thank you for your attention.

Thanks, I'll look into this. The fix seems fine at a quick glance, but I'll think about the performance aspect a bit more.
I apologize for the mistake in my patch: "if GinPageIsIncompleteSplit(page)" is
missing a parenthesis, it should be "if (GinPageIsIncompleteSplit(page))"

Another way to create a scenario with incomplete splits, which doesn't involve any crashes or errors, would be to perform PITR to just between the insert and the finish-split records. But the fault-injection seems easier.
I agree it, fault-injection is easier than PITR.

Best Regards,
Fei Changhong
Alibaba Cloud Computing Ltd.

pgsql-bugs by date:

Previous
From: "Fensterman, John P"
Date:
Subject: RE: [EXTERNAL] Re: BUG #18289: postgresql14-devel-14.10-2PGDG.rhel8.x86_64.rpm Contains invalid cLang option in Makefile.global
Next
From: Tom Lane
Date:
Subject: Re: BUG #18305: Unexpected error: "WindowFunc not found in subplan target lists" triggered by subqueries