Re: Remove sort files - Mailing list pgsql-patches

From Ian Lance Taylor
Subject Re: Remove sort files
Date
Msg-id silmnn8tfw.fsf@daffy.airs.com
Whole thread Raw
In response to Re: Remove sort files  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Remove sort files
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:

> +                     if (temp_de->d_type == DT_REG)

The d_type field, and the corresponding macros such as DT_REG, are not
portable.

The only portable field in the dirent structure is d_name.

If you want to be really really super portable, you have to think
about supporting direct.h and other header files.  See AC_DIR_HEADER
and AC_HEADER_DIRENT in the autoconf documentation.  But these days
probably every OS of interest supports dirent.h, which is defined by
POSIX.

Ian

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Remove sort files
Next
From: Bruce Momjian
Date:
Subject: Re: Remove sort files