Re: pending patch: Re: HS/SR and smart shutdown - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: pending patch: Re: HS/SR and smart shutdown
Date
Msg-id s2g3f0b79eb1003310148g41eefdf9g2fe173d065029c78@mail.gmail.com
Whole thread Raw
In response to Re: pending patch: Re: HS/SR and smart shutdown  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: pending patch: Re: HS/SR and smart shutdown
List pgsql-hackers
On Wed, Mar 31, 2010 at 5:00 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
> Please add some docs that a) explains what the patch does and b) notes
> any changes from behaviour in previous releases. ISTM this is a major
> change in behaviour.

How about adding the following description into "17.5. Shutting Down
the Server"?
   If the server is in recovery, it waits for all of the read only   connections to be closed.

And, where should the note be put in? AFAIK, the previous behavior
has not been documented anywhere.

> >From what I have seen, the comment about PM_WAIT_BACKENDS is incorrect.
> "backends might be waiting for the WAL record that conflicts with their
> queries to be replayed". Recovery sometimes waits for backends, but
> backends never wait for recovery.

Really? As Heikki explained before, backends might wait for the lock
taken by the startup process.
http://archives.postgresql.org/pgsql-hackers/2010-01/msg02984.php

Regards,

-- 
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


pgsql-hackers by date:

Previous
From: Boszormenyi Zoltan
Date:
Subject: ECPG pointer vs array
Next
From: Simon Riggs
Date:
Subject: Re: pending patch: Re: HS/SR and smart shutdown