Re: Add min and max execute statement time in pg_stat_statement - Mailing list pgsql-hackers

From Arne Scheffer
Subject Re: Add min and max execute statement time in pg_stat_statement
Date
Msg-id permail-201501201826078954262000006bbe-scheffa@message-id.uni-muenster.de
Whole thread Raw
In response to Re: Add min and max execute statement time in pg_stat_statement  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: Add min and max execute statement time in pg_stat_statement
List pgsql-hackers
Interesting patch.
I did a quick review looking only into the patch file.

The "sum of variances" variable contains
the "sum of squared differences" instead, I think.

And a very minor aspect:
The term "standard deviation" in your code stands for
(corrected) sample standard deviation, I think,
because you devide by n-1 instead of n to keep the
estimator unbiased.
How about mentioning the prefix "sample"
to indicate this beiing the estimator?

And I'm sure I'm missing C specifics (again)
(or it's the reduced patch file scope),
but you introduce sqrtd, but sqrt is called?

VlG

Arne













pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: Reducing buildfarm disk usage: remove temp installs when done
Next
From: Jeff Davis
Date:
Subject: Re: PATCH: decreasing memory needlessly consumed by array_agg