Fixed outfuncs - Mailing list pgsql-hackers

From jwieck@debis.com (Jan Wieck)
Subject Fixed outfuncs
Date
Msg-id m0zr1VI-000EBPC@orion.SAPserv.Hamburg.dsh.de
Whole thread Raw
List pgsql-hackers
Hi,

    just  committed  some fixes to get back the old "<>" for NULL
    strings on nodeToString().

    Marc's recent changes to  appendStringInfo()  handling  broke
    it.  The  old  version  converted  a NULL string into a "<>".
    Handing a  NULL  for  %s  to  vsnprintf()  is  implementation
    dependent  (some  put nothing, some put (null) and some might
    simply crash - but none puts "<>").

    There is a new  macro  stringStringInfo(s)  in  include/lib.h
    which  checks  for  NULL  and substitutes by "<>". All string
    arguments to appendStringInfo() are now  embedded  into  that
    (also in commands/explain.c).

    Regression tests for select_views, rules and plpgsql are O.K.
    again.


Jan

--

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#======================================== jwieck@debis.com (Jan Wieck) #

pgsql-hackers by date:

Previous
From: "PCblazer"
Date:
Subject: Total Multimedia Board & CPU deal
Next
From: "Thomas G. Lockhart"
Date:
Subject: Re: [HACKERS] CURRENT: crash in select_view regression test...