Patch for libpgtcl - Mailing list pgsql-hackers

Hi,

    found a little bug in libpgtcl/pgtclCmds.c causing a
    segmentation fault. Please apply.


Jan

--

#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#======================================== jwieck@debis.com (Jan Wieck) #

*** pgtclCmds.c.orig    Thu Oct  1 09:15:11 1998
--- pgtclCmds.c    Thu Oct  1 12:59:59 1998
***************
*** 241,258 ****
  {
      PQconninfoOption *option;
      char        buf[8192];

      Tcl_ResetResult(interp);
      for (option = PQconndefaults(); option->keyword != NULL; option++)
      {
!         if (option->val == NULL)
!             option->val = "";
          sprintf(buf, "{%s} {%s} {%s} %d {%s}",
                  option->keyword,
                  option->label,
                  option->dispchar,
                  option->dispsize,
!                 option->val);
          Tcl_AppendElement(interp, buf);
      }

--- 241,258 ----
  {
      PQconninfoOption *option;
      char        buf[8192];
+     char        *val;

      Tcl_ResetResult(interp);
      for (option = PQconndefaults(); option->keyword != NULL; option++)
      {
!         val = (option->val == NULL) ? "" : option->val;
          sprintf(buf, "{%s} {%s} {%s} %d {%s}",
                  option->keyword,
                  option->label,
                  option->dispchar,
                  option->dispsize,
!                 val);
          Tcl_AppendElement(interp, buf);
      }