Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] PATCH: recursive json_populate_record() - Mailing list pgsql-hackers

From Nikita Glukhov
Subject Re: [HACKERS] PATCH: recursive json_populate_record()
Date
Msg-id fbd1d566-bba0-a3de-d6d0-d3b1d7c24ff2@postgrespro.ru
Whole thread Raw
In response to Re: [HACKERS] PATCH: recursive json_populate_record()  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: [HACKERS] PATCH: recursive json_populate_record()  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: [HACKERS] PATCH: recursive json_populate_record()  (Noah Misch <noah@leadboat.com>)
List pgsql-hackers
Tree view 
Attached two small fixes for the previous committed patch:

1. I've noticed a difference in behavior between json_populate_record()
and  jsonb_populate_record() if we are trying to populate record from a
non-JSON-object: json function throws an error but jsonb function returns
a record with NULL fields. So I think it would be better to throw an error
in jsonb case too, but I'm not sure.

2. Also I've found a some kind of thinko in JsGetObjectSize() macro, but it
seems that this obvious mistake can not lead to incorrect behavior.

--
Nikita Glukhov
Postgres Professional:http://www.postgrespro.com
The Russian Postgres Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachment

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: [HACKERS] psql - add special variable to reflect the last query status
Next
From: Fabien COELHO
Date:
Subject: Re: [HACKERS] psql - add special variable to reflect the last querystatus