Re: Temporary WAL segments files not cleaned up after an instancecrash - Mailing list pgsql-hackers

On 12/07/18 15:38, Michael Paquier wrote:
> On Thu, Jul 12, 2018 at 01:15:03PM +0300, Heikki Linnakangas wrote:
>> On 12/07/18 10:44, Michael Paquier wrote:
>>> +        snprintf(path, MAXPGPATH, XLOGDIR "/%s", xlde->d_name);
>>> +        elog(DEBUG2, "removed temporary WAL file \"%s\"", path);
>>> +        unlink(path);
>>
>> The elog message says "removed", but the removal actually happens after the
>> elog. "removing" would be more accurate.
> 
> Or just move the elog() after the file is actually removed?  Would you
> be fine with that?

Sure.

- Heikki