Re: Set appropriate processing mode for auxiliary processes. - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Set appropriate processing mode for auxiliary processes.
Date
Msg-id f8b36c59-3f5b-49c7-a063-c6cdf71709f6@iki.fi
Whole thread Raw
In response to Set appropriate processing mode for auxiliary processes.  (Xing Guo <higuoxing@gmail.com>)
Responses Re: Set appropriate processing mode for auxiliary processes.  (Xing Guo <higuoxing@gmail.com>)
Re: Set appropriate processing mode for auxiliary processes.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 09/05/2024 16:12, Xing Guo wrote:
> Hi hackers,
> 
> After several refactoring iterations, auxiliary processes are no
> longer initialized from the bootstrapper. I think using the
> InitProcessing mode for initializing auxiliary processes is more
> appropriate.

At first I was sure this was introduced by my refactorings in v17, but 
in fact it's been like this forever. I agree that InitProcessing makes 
much more sense. The ProcessingMode variable is initialized to 
InitProcessing, so I think we can simply remove that line from 
AuxiliaryProcessMainCommon(). There are existing 
"SetProcessingMode(InitProcessing)" calls in other Main functions too 
(AutoVacLauncherMain, BackgroundWorkerMain, etc.), and I think those can 
also be removed.

-- 
Heikki Linnakangas
Neon (https://neon.tech)




pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: request for database identifier in the startup packet
Next
From: Bruce Momjian
Date:
Subject: Re: First draft of PG 17 release notes