Re: Define jsonpath functions as stable - Mailing list pgsql-hackers

From Erik Rijkers
Subject Re: Define jsonpath functions as stable
Date
Msg-id f7d13fa3bfe17e0d6c0160501bed1117@xs4all.nl
Whole thread Raw
In response to Re: Define jsonpath functions as stable  ("Jonathan S. Katz" <jkatz@postgresql.org>)
Responses Re: Define jsonpath functions as stable
List pgsql-hackers
On 2019-09-17 17:38, Jonathan S. Katz wrote:
> On 9/16/19 6:39 PM, Jonathan S. Katz wrote:
> [regex.patch]

A few things/typos caught my eye:

1.
'implementation' seems the wrong word in sentence:

"Several other parts of the SQL standard
also define LIKE_REGEX equivalents that refer
to this implementation, including the
SQL/JSON path like_regex filter."

As I understand this text, 'concept' seems better.
I'd drop 'also', too.

2.
'whereas the POSIX will those'  should be
'whereas POSIX will regard those'
  or maybe 'read those'

3.
+     The SQL/JSON standard borrows its definition for how regular 
expressions
+     from the <literal>LIKE_REGEX</literal> operator, which in turns 
uses the
+     XQuery standard.
That sentence needs the verb 'work', no?  'for how regular expressions 
work [..]'
Or alternatively drop 'how'.


thanks,

Erik Rijkers





pgsql-hackers by date:

Previous
From: Marina Polyakova
Date:
Subject: pg_upgrade check fails on Solaris 10
Next
From: Stephen Frost
Date:
Subject: Re: block-level incremental backup