Re: [PATCH] Better logging of COPY queries if log_statement='all' - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [PATCH] Better logging of COPY queries if log_statement='all'
Date
Msg-id f7203334-95b4-779a-f3ee-3319e6366861@dunslane.net
Whole thread Raw
In response to [PATCH] Better logging of COPY queries if log_statement='all'  (Aleksander Alekseev <a.alekseev@postgrespro.ru>)
Responses Re: [PATCH] Better logging of COPY queries if log_statement='all'
List pgsql-hackers

On 10/17/2016 09:57 AM, Aleksander Alekseev wrote:
> Hello.
>
> Sometimes it's useful to log content of files used in COPY ... TO ... and
> COPY ... FROM ... queries. Unfortunately PostgreSQL doesn't allow to do
> it, even if log_statement='all'. Suggested patch fixes this.
>
> Log example:
>
> ```
> LOG:  statement: create table test (k int, v text);
> LOG:  statement: insert into test values (111, 'aaa'), (222, 'bbb');
> LOG:  statement: copy test to '/tmp/copy.txt';
> LOG:  statement: 111    aaa
> LOG:  statement: 222    bbb
> LOG:  statement: delete from test;
> LOG:  statement: copy test from '/tmp/copy.txt';
> LOG:  statement: 111    aaa
> LOG:  statement: 222    bbb
> ```


I'm not in favor of this, especially if it's not even optional. 
log_statement is about logging, er, statements, not logging data.

cheers

andrew



pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: [PATCH] Better logging of COPY queries if log_statement='all'
Next
From: Heikki Linnakangas
Date:
Subject: Re: Use EVP API pgcrypto encryption, dropping support for OpenSSL 0.9.6 and older