On 06.03.25 21:23, Robert Haas wrote:
> On Wed, Mar 5, 2025 at 4:38 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> v4 has addressed most of my nitpicks, but you still have typedefs
>> for ExplainState in both header files. My bet is that at least
>> one buildfarm animal will complain about that. I could be wrong
>> though, maybe all such compilers are in disuse now.
>
> Ugh, I suck at this, sorry. Adjusted in v5. It's hard to avoid the
> conclusion that our IWYU configuration must be fairly lenient, because
> every change seems to surface more source files that are depending on
> indirect includes.
Just to clarify this: Nobody has gone through and used IWYU to clean up
indirect includes, as you appear to imagine here. My recent IWYU work
was, besides putting some infrastructure in place, to clean up includes
that are completely unneeded. Indirect includes cleanup is a different
project that is not currently happening, AFAIK.
Also, benign typedef redefinitions are a C11 feature. In practice, all
compilers currently in play support it, and the only problem you'll get
is from the buildfarm members that are explicitly set up to warn about
accidental C11 use. We could probably have a discussion about that, but
for this patch set, it's probably better to just deal with the status quo.
