Re: TAP tests and symlinks on Windows - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: TAP tests and symlinks on Windows
Date
Msg-id f282d377-c9a0-0ea2-6f15-f311fadf6b3c@2ndquadrant.com
Whole thread Raw
In response to Re: TAP tests and symlinks on Windows  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
List pgsql-hackers
On 2020-07-10 13:58, Andrew Dunstan wrote:
> After much frustration and gnashing of teeth here's a patch that allows
> almost all the TAP tests involving symlinks to work as expected on all
> Windows build environments, without requiring an additional Perl module.
> I have tested this on a system that is very similar to that running
> drongo and fairywren, with both msys2 and  MSVC builds.

Thanks.  This patch works for me in my environment.  The code changes 
look very clean, so it seems like a good improvement.

Attached is a small fixup patch for some typos and a stray debug message.

A perltidy run might be worthwhile, as Michael already mentioned.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Parallel Seq Scan vs kernel read ahead
Next
From: Dilip Kumar
Date:
Subject: Re: INSERT INTO SELECT, Why Parallelism is not selected?