Re: Handle infinite recursion in logical replication setup - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Handle infinite recursion in logical replication setup
Date
Msg-id ede2851d-0f7d-b57a-8021-8250f40c316d@eisentraut.org
Whole thread Raw
In response to Re: Handle infinite recursion in logical replication setup  (vignesh C <vignesh21@gmail.com>)
Responses Re: Handle infinite recursion in logical replication setup  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On 12.09.22 07:23, vignesh C wrote:
> On Fri, 9 Sept 2022 at 11:12, Amit Kapila <amit.kapila16@gmail.com> wrote:
>>
>> On Thu, Sep 8, 2022 at 9:32 AM vignesh C <vignesh21@gmail.com> wrote:
>>>
>>>
>>> The attached patch has the changes to handle the same.
>>>
>>
>> Pushed. I am not completely sure whether we want the remaining
>> documentation patch in this thread in its current form or by modifying
>> it. Johnathan has shown some interest in it. I feel you can start a
>> separate thread for it to see if there is any interest in the same and
>> close the CF entry for this work.
> 
> Thanks for pushing the patch. I have closed this entry in commitfest.
> I will wait for some more time and see the response regarding the
> documentation patch and then start a new thread if required.

This patch added the following error message:

errdetail_plural("Subscribed publication %s is subscribing to other 
publications.",
"Subscribed publications %s are subscribing to other publications.",
list_length(publist), pubnames->data),

But in PostgreSQL, a publication cannot subscribe to a publication, so 
this is not giving accurate information.  Apparently, what it is trying 
to say is that

The subscription that you are creating subscribes to publications that 
contain tables that are written to by other subscriptions.

Can we get to a more accurate wording like this?

There is also a translatability issue there, in the way the publication 
list is pasted into the message.

Is the list of affected publications really that interesting?  I wonder 
whether the list of affected tables might be more relevant?




pgsql-hackers by date:

Previous
From: Dean Rasheed
Date:
Subject: Re: [PATCH] psql: Add tab-complete for optional view parameters
Next
From: Etsuro Fujita
Date:
Subject: Re: postgres_fdw: wrong results with self join + enable_nestloop off