Re: TAP test started using meson, can get a tcp port already used by another test. - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: TAP test started using meson, can get a tcp port already used by another test.
Date
Msg-id eb22ad13-4666-4c51-a98d-5774b34ee1b8@dunslane.net
Whole thread Raw
In response to Re: TAP test started using meson, can get a tcp port already used by another test.  (Andres Freund <andres@anarazel.de>)
Responses Re: TAP test started using meson, can get a tcp port already used by another test.
List pgsql-hackers
On 2025-02-21 Fr 10:50 AM, Andres Freund wrote:
>
>
>> Can we explicitly set the MESON_BUILD_ROOT environment variable when running
>> a test? With included patch for the src/tools/testwrap file, each instance
>> gets an unique TCP port.
> I don't like that, feels like a "namespace violation" to set a MESON_*
> variable, why not set the top_builddir or a dedicated variable?
>
> And I don't think it should be done in testwrap, but to test_env in the
> top-level meson.build.
>
> Something like the attached?
>

LGTM


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: generic plans and "initial" pruning
Next
From: Tom Lane
Date:
Subject: Re: Redact user password on pg_stat_statements