Postgres Pro
Downloads
Home   >   mailing lists

Re: table inheritance versus column compression and storage settings - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: table inheritance versus column compression and storage settings
Date
Msg-id eb076b15-64b5-4992-b232-9e00603e0849@eisentraut.org
Whole thread Raw
In response to Re: table inheritance versus column compression and storage settings  (Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>)
Responses Re: table inheritance versus column compression and storage settings
List pgsql-hackers
Tree view 
On 08.02.24 08:20, Ashutosh Bapat wrote:
> On Wed, Feb 7, 2024 at 12:47 PM Ashutosh Bapat
> <ashutosh.bapat.oss@gmail.com> wrote:
> 
>> 0001 fixes compression inheritance
>> 0002 fixes storage inheritance
>>
> 
> The first patch does not update compression_1.out which makes CI
> unhappy. Here's patchset fixing that.

The changed behavior looks good to me.  The tests are good, the code 
changes are pretty straightforward.

Did you by any change check that pg_dump dumps the resulting structures 
correctly?  I notice in tablecmds.c that ALTER COLUMN SET STORAGE 
recurses but ALTER COLUMN SET COMPRESSION does not.  I don't understand 
why that is, and I wonder whether it affects pg_dump.

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions
Next
From: Peter Eisentraut
Date:
Subject: Re: Support a wildcard in backtrace_functions