On 2025-02-20 Th 4:39 AM, Jeff Davis wrote:
> On Wed, 2025-02-12 at 19:00 -0800, Jeff Davis wrote:
>> I'm still reviewing v48, but I intend to commit something soon.
> Committed with some revisions on top of v48:
>
> * removed the short option -X, leaving the long option "--statistics-
> only" with the same meaning.
>
> * removed the redundant --with-statistics option for pg_upgrade,
> because that's the default anyway.
>
> * removed an unnecessary enum TocEntryType and cleaned up the API to
> just pass the desired prefix directly to _printTocEntry().
>
> * stabilized the 002_pg_upgrade test by turning off autovacuum before
> the first pg_dumpall (we still want it to run before that to collect
> stats).
>
> * stabilized the 027_stream_regress recovery test by specifying --no-
> statistics when comparing the data on primary and standby
>
> * fixed the cross-version upgrade tests by using the
> adjust_old_dumpfile to replace the version specifier with 000000 in the
> argument list to pg_restore_* functions.
>
The buildfarm doesn't like with this.
<https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=crake&dt=2025-02-20%2009%3A32%3A03&stg=xversion-upgrade-REL9_2_STABLE-HEAD>
The conversion regexes are wrong for versions < 10, where the major
version is '9.x', but that just seems to be the tip of the iceberg.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
