On 07/06/2018 07:18 AM, Michael Paquier wrote:
> Robert Haas wrote:
>> Although the state is now back to "Needs Review", I echo those
>> sentiments. This issue has now been hanging around for about 18
>> months.
No, those are my words, not Robert's :-)
> For what it's worth, I volunteer to finish the work :)
>
> The 2PC patch is really simple, and fixes a data loss issue. The second
> patch has been looked up by Heikki, Magnus and me at least once by each,
> and there is visibly an agreement on having it. Having reviews after
> a new patch version is sent, by somebody else than the one who sent the
> patches is of course always nice..
If you're comfortable committing it then go for it. It will be good to
have the CF item resolved.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
