Re: pgsql: Make WAL segment size configurable at initdb time. - Mailing list pgsql-committers

From David Steele
Subject Re: pgsql: Make WAL segment size configurable at initdb time.
Date
Msg-id e6d444e7-b203-52a0-a73c-f30ca94798ee@pgmasters.net
Whole thread Raw
In response to Re: pgsql: Make WAL segment size configurable at initdb time.  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pgsql: Make WAL segment size configurable at initdb time.  (David Steele <david@pgmasters.net>)
List pgsql-committers
On 9/21/18 12:53 AM, Michael Paquier wrote:
> On Thu, Sep 20, 2018 at 06:23:54PM -0700, Andres Freund wrote:
>> 16*M*B, right?  If so, that's normal - pg_settings just reports the
>> values in the underlying unit - which is XLOG_BLCKSZ, compile-time
>> defaulting to 8KB. 8192 * 2048 = 16MB.  That's the same in various other
>> settings.
>
> Would it bring less confusion if we append something like "When querying
> pg_settings"?  I can see David's point the current phrasing is
> confusing: we don't know if this comes from pg_settings or from SHOW.
> It obviously refers to the former, but one can understand that it refers
> to the latter.
>
> A second parameter in config.sgml where this formulation is used is
> segment_size.

That's why I used a default of 16MB instead of the byte value, because
segment_size used 1GB instead of the byte value.

--
-David
david@pgmasters.net


Attachment

pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: pgsql: Document lock taken on referenced table when adding a foreignke
Next
From: Thomas Munro
Date:
Subject: pgsql: Use size_t consistently in dsa.{ch}.