Re: [PATCH] Add min() and max() aggregate functions for xid8 - Mailing list pgsql-hackers

Thank you for the comments!

> if (FullTransactionIdFollows(fxid1, fxid2))
>     PG_RETURN_FULLTRANSACTIONID(fxid1);
> else
>     PG_RETURN_FULLTRANSACTIONID(fxid2);

> Isn't it better to use '0xffffffffffffffff'::xid8 instead of
> '18446744073709551615'::xid8, to more easily understand that this test
> uses maximum number allowed as xid8?

I updated these two parts as you suggested.


> In addition to those two xid8 values, IMO it's better to insert also
> the xid8 value neither minimum nor maximum xid8 ones, for example,
> '42'::xid8.

I added '010'::xid8, '42'::xid8, and '-1'::xid8
in addition to '0'::xid8 and '0xffffffffffffffff'::xid8
just to have more varieties.


Best wishes,

-- 
Ken Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION