On 5/5/2025 15:56, Alexander Pyhalov wrote:
> Andrei Lepikhov писал(а) 2025-05-05 14:38:
> Also logic a bit differs if path is NULL. In
> get_cheapest_path_for_pathkeys_ext() we explicitly check for path being
> NULL, in get_cheapest_fractional_path_for_pathkeys_ext() only after
> calculating sort cost.
>
> I've tried to fix comments a bit and unified functions definitions.
Generally seems ok, I'm not a native speaker to judge the comments. But:
if (base_path && path != base_path)
What is the case in your mind where the base_path pointer still may be
null at that point?
--
regards, Andrei Lepikhov
