Re: cleanup temporary files after crash - Mailing list pgsql-hackers

From Euler Taveira
Subject Re: cleanup temporary files after crash
Date
Msg-id e1b4f05d-54ec-4f51-832b-c18cf5a161c0@www.fastmail.com
Whole thread Raw
In response to cleanup temporary files after crash  (Euler Taveira <euler.taveira@2ndquadrant.com>)
List pgsql-hackers
On Fri, Jun 11, 2021, at 9:43 PM, Justin Pryzby wrote:
On Sat, Oct 31, 2020 at 09:01:15PM -0300, Euler Taveira wrote:
> > > The current behavior is only useful for debugging purposes.

On Wed, 28 Oct 2020 at 15:42, Tomas Vondra <tomas.vondra@2ndquadrant.com> wrote:
> > One thing I'm not sure about is whether we should have the GUC as
> > proposed, or have a negative "keep_temp_files_after_restart" defaulting
> > to false. But I don't have a very good justification for the alternative
> > other than vague personal preference.

On Sat, Oct 31, 2020 at 09:01:15PM -0300, Euler Taveira wrote:
> I thought about not providing a GUC at all or provide it in the developer
> section. I've never heard someone saying that they use those temporary
> files to investigate an issue. Regarding a crash, all information is already
> available and temporary files don't provide extra details. This new GUC is just to keep the
> previous behavior. I'm fine without the GUC, though.

Should this GUC be classified as a developer option, and removed from
postgresql.sample.conf ?
It probably should.

That was discussed initially in October but not since.
Was it? I seem to have missed this suggestion.

I'm attaching a patch to fix it.


--
Euler Taveira

Attachment

pgsql-hackers by date:

Previous
From: Fabien COELHO
Date:
Subject: Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors
Next
From: Greg Sabino Mullane
Date:
Subject: Re: Avoid stuck of pbgench due to skipped transactions