Re: Check return value of pclose() correctly - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Check return value of pclose() correctly
Date
Msg-id e185b889-dc0b-f49a-1260-3e152a69bef8@enterprisedb.com
Whole thread Raw
In response to Re: Check return value of pclose() correctly  (Ankit Kumar Pandey <itsankitkp@gmail.com>)
List pgsql-hackers
On 02.11.22 16:26, Ankit Kumar Pandey wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, passed
> Implements feature:       tested, passed
> Spec compliant:           tested, passed
> Documentation:            tested, passed
> 
> Hi Peter,
> This is a review of the pclose return value check patch:
> 
> Contents & Purpose:
> Purpose of this patch is to properly handle return value of pclose (indirectly, return from ClosePipeStream).
> 
> Initial Run:
> The patch applies cleanly to HEAD. The regression tests all pass
> successfully against the new patch.
> 
> Conclusion:
> At some places pclose return value is handled and this patch adds return value check for remaining values.
> Implementation is in sync with existing handling of pclose.

Committed.  Thanks for the review.




pgsql-hackers by date:

Previous
From: "Karthik Jagadish (kjagadis)"
Date:
Subject: Vacuumdb --force-index-cleanup option not available in postgres 12.9
Next
From: Peter Eisentraut
Date:
Subject: Re: dynamic result sets support in extended query protocol