Re: [PATCH] pg_stat_statements dealloc field ignores manual deallocation - Mailing list pgsql-hackers

From Andrei Zubkov
Subject Re: [PATCH] pg_stat_statements dealloc field ignores manual deallocation
Date
Msg-id e0904bf7a92beeefdd17a773212514bb84e91bed.camel@moonset.ru
Whole thread Raw
In response to Re: [PATCH] pg_stat_statements dealloc field ignores manual deallocation  (Julien Rouhaud <rjuju123@gmail.com>)
List pgsql-hackers
On Fri, 2021-03-19 at 22:15 +0800, Julien Rouhaud wrote:
> I disagree.  The point of that field is to help users configuring
> pg_stat_statements.max, as evictions have a huge overhead in many
> workloads.
> 
> If users remove entries for some reasons, we don't have to give the
> impression
> that pg_stat_statements.max is too low and that it should be
> increased,
> especially since it requires a restart.
> 
Ok.
But when we are collecting aggregated statistics on pg_stat_statememts
periodically it would be great to know about every deallocation
happened. Maybe we need to add another counter for manual deallocations
tracking?




pgsql-hackers by date:

Previous
From: Konstantin Knizhnik
Date:
Subject: Re: Built-in connection pooler
Next
From: Andrei Zubkov
Date:
Subject: [PATCH] Tracking statements entry timestamp in pg_stat_statements