Re: TODO items for window functions - Mailing list pgsql-hackers

From Hitoshi Harada
Subject Re: TODO items for window functions
Date
Msg-id e08cc0400902042035i677c21efh27325df1f94d5775@mail.gmail.com
Whole thread Raw
In response to Re: TODO items for window functions  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
2009/2/5 Bruce Momjian <bruce@momjian.us>:
> Robert Haas wrote:
>> > I am not thrilled about inventing a new column for this, but how about
>> > a display like so:
>> >
>> > regression=# \df nth_value
>> >                        List of functions
>> >   Schema   |   Name    | Result data type |       Argument data types
>> > ------------+-----------+------------------+---------------------------------
>> >  pg_catalog | nth_value | anyelement       | anyelement, integer OVER window
>> >
>> > or some other addition that only shows up when needed.
>>
>> I think this whole idea is a bad one.  In the current release, you can do
>>
>> DROP FUNCTION Name ( Argument data types )
>>
>> ...and it will work.  Maybe you will say that no one is doing this via
>> a script (which I wouldn't bet on, but it's possible) but I'm sure
>> people are doing it via cut and paste, because I have done exactly
>> this thing.  Any of the various proposals for hacking up Argument data
>> types will make this no longer true, and somebody will get confused.
>> I think you should bite the bullet and add a "type" column (f for
>> regular function and w for window?  could there be others in the
>> future?).
>
> Are we doing anything for this for 8.4?

I prefer adding column of type 'w'|'f' to attaching OVER keyword in
argument column, because type column approach is more general if it
may refer to not only window functions but also setof, trigger, and
those coming in the future (hypothetical set function maybe?). It
seems to me that the OVER keyword is not necessary to let him know he
needs it.

Regards,



-- 
Hitoshi Harada


pgsql-hackers by date:

Previous
From: Andrew Chernow
Date:
Subject: Re: Is a plan for lmza commpression in pg_dump
Next
From: Fujii Masao
Date:
Subject: Re: Synch Replication