Re: Windowing Function Patch Review -> NTH_VALUE - Mailing list pgsql-hackers

From Hitoshi Harada
Subject Re: Windowing Function Patch Review -> NTH_VALUE
Date
Msg-id e08cc0400811100624o77744b15me1bc009b74d292c1@mail.gmail.com
Whole thread Raw
In response to Windowing Function Patch Review -> NTH_VALUE  ("David Rowley" <dgrowley@gmail.com>)
Responses Re: Windowing Function Patch Review -> NTH_VALUE  ("Hitoshi Harada" <umi.tanuki@gmail.com>)
List pgsql-hackers
2008/11/9 David Rowley <dgrowley@gmail.com>:
> I'm having a little trouble understanding the standard for NTH_VALUE(). I
> would have assumed that NTH_VALUE(name,1) would return the first name in the
> window. The current patch is using 0 for the first.
>

Hmmm, good point... I haven't thought about it enough, just followed
the internal design. The window_seek() in nodeWindow.c, which is an
internal API, counts rows from 0 so the external behavior is simlar.
Nothing more :-P

Giving your comment, actually it seems to me strange that row_number()
returns 1 for the first row whereas the ntile(ve, 1) returns the
second. If there're no objections I will change it as you told.

Regards,


-- 
Hitoshi Harada


pgsql-hackers by date:

Previous
From: "Hitoshi Harada"
Date:
Subject: Re: Windowing Function Patch Review -> NTILE function
Next
From: Ron Mayer
Date:
Subject: Re: Patch for ISO-8601-Interval Input and output.