Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak - Mailing list pgsql-hackers

From Qingqing Zhou
Subject Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak
Date
Msg-id djb9vu$1k2p$1@news.hub.org
Whole thread Raw
In response to Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak  ("Magnus Hagander" <mha@sollentuna.net>)
Responses Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak
Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance
List pgsql-hackers
"Tom Lane" <tgl@sss.pgh.pa.us> wrote
>
> ... so definitely worth fixing for 8.1 if we can convince ourselves
> it's correct.
>

Despite the performance, there is one thing I am not exactly sure. Shall we 
add "volatile" quanlifier to at least pg_signal_queue? The dangerous place 
is PGSemaphoreLock(). If the compiler cache this value somehow, then we are 
in trouble, but the original way (check event directly) does not have this 
problem.

Regards,
Qingqing





pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak
Next
From: "Merlin Moncure"
Date:
Subject: Re: [PATCHES] Win32 CHECK_FOR_INTERRUPTS() performance tweak