Re: "unexpected duplicate for tablespace" problem in logical replication - Mailing list pgsql-bugs

From wangsh.fnst@fujitsu.com
Subject Re: "unexpected duplicate for tablespace" problem in logical replication
Date
Msg-id dff776f7-fd73-6b14-a6c0-fba8c3858735@fujitsu.com
Whole thread Raw
In response to RE: "unexpected duplicate for tablespace" problem in logical replication  ("osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>)
Responses Re: "unexpected duplicate for tablespace" problem in logical replication  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
List pgsql-bugs
Hi, Osumi-san, Thank you for your comment.

On 4/11/22 15:40, Osumi, Takamichi/大墨 昂道 wrote:
> (1) Name of isRelNodeCollision
changed.
> (2) Remove curly brackets for one sentence
changed.
> (3) variables of isRelNodeCollision
changed.
> (4) Having Assert in isRelNodeCollision
added.
> (5) argument name of isRelNodeCollision
changed.

BTW, I also change the parameter from null to SnapshotAny

         scandesc = systable_beginscan(pg_class,
                                       ClassTblspcRelfilenodeIndexId,
-                                      true, NULL, 2, skey);
+                                      true, SnapshotAny, 2, skey);

I'm not sure, but I think SnapshotAny is more suitable after reading the 
source(comment) in function GetNewOidWithIndex().

Please see the attachment

Regards,
Shenhao Wang

Attachment

pgsql-bugs by date:

Previous
From: PG Bug reporting form
Date:
Subject: BUG #17462: Invalid memory access in heapam_tuple_lock
Next
From: Tom Lane
Date:
Subject: Re: BUG #17462: Invalid memory access in heapam_tuple_lock