Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] json_lex_string: don't overread on bad UTF8 - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] json_lex_string: don't overread on bad UTF8
Date
Msg-id df114cad-3ee0-42ea-8ee5-d8024dfa8a75@eisentraut.org
Whole thread Raw
In response to [PATCH] json_lex_string: don't overread on bad UTF8  (Jacob Champion <jacob.champion@enterprisedb.com>)
Responses Re: [PATCH] json_lex_string: don't overread on bad UTF8
List pgsql-hackers
Tree view 
On 30.04.24 19:39, Jacob Champion wrote:
> Tangentially: Should we maybe rethink pieces of the json_lex_string
> error handling? For example, do we really want to echo an incomplete
> multibyte sequence once we know it's bad?

I can't quite find the place you might be looking at in 
json_lex_string(), but for the general encoding conversion we have what 
would appear to be the same behavior in report_invalid_encoding(), and 
we go out of our way there to produce a verbose error message including 
the invalid data.

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: wrong comment in libpq.h
Next
From: Peter Eisentraut
Date:
Subject: Re: pg_trgm comparison bug on cross-architecture replication due to different char implementation