Re: fix crash with Python 3.11 - Mailing list pgsql-hackers

From Markus Wanner
Subject Re: fix crash with Python 3.11
Date
Msg-id defd749a-8410-841d-1126-21398686d63d@enterprisedb.com
Whole thread Raw
In response to Re: fix crash with Python 3.11  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: fix crash with Python 3.11  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: fix crash with Python 3.11  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
On 6/21/22 18:33, Tom Lane wrote:
> My inclination at this point is to not back-patch the second change
> 12d768e70 ("Don't use static storage for SaveTransactionCharacteristics").
> It's not clear that the benefit would be worth even a small risk of
> somebody being unhappy about the API break.

Actually, the backport of 2e517818f ("Fix SPI's handling of errors") 
already broke the API for code using SPICleanup, as that function had 
been removed. Granted, it's not documented, but still exported.

I propose to re-introduce a no-op placeholder similar to what we have 
for SPI_start_transaction, somewhat like the attached patch.

Regards

Markus
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size
Next
From: Michael Paquier
Date:
Subject: Re: Fix typo in pg_publication.c