Re: fairywren is generating bogus BASE_BACKUP commands - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: fairywren is generating bogus BASE_BACKUP commands
Date
Msg-id d9648ebe-7f41-cbac-e48a-bca4fb4cc021@dunslane.net
Whole thread Raw
In response to Re: fairywren is generating bogus BASE_BACKUP commands  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: fairywren is generating bogus BASE_BACKUP commands
Re: fairywren is generating bogus BASE_BACKUP commands
List pgsql-hackers
On 1/23/22 22:52, Robert Haas wrote:
> On Sun, Jan 23, 2022 at 4:09 PM Andrew Dunstan <andrew@dunslane.net> wrote:
>> The most common issues we get are around this issue of virtualized paths
>> in the TAP tests. If people followed the rule I suggested upthread, 99%
>> of those problems would go away.
> Well, that makes it sound like it's the fault of people for not
> following the rules, but I don't think that's really a fair
> assessment. Even your first guess as to how to solve this particular
> problem wasn't correct, and if you can't guess right on the first try,
> I don't know how anyone else is supposed to do it. I still don't even
> understand why your first guess wasn't right. I feel like every time I
> try to add a TAP test Msys blows up, and I can't figure out how to fix
> it myself. Which is not a great feeling.
>


Well if we can get Andres' suggestion to work all this might go away,
which would keep everyone happy, especially me. You're right that I was
a little careless upthread. Mea culpa. Meanwhile I am committing a
minimal one line fix.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-hackers by date:

Previous
From: "Euler Taveira"
Date:
Subject: Re: [BUG]Update Toast data failure in logical replication
Next
From: Andrew Dunstan
Date:
Subject: Re: CREATEROLE and role ownership hierarchies