Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition - Mailing list pgsql-hackers

From ilmari@ilmari.org (Dagfinn Ilmari Mannsåker)
Subject Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition
Date
Msg-id d8jimnzq3ow.fsf@dalvik.ping.uio.no
Whole thread Raw
In response to Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Tree view 
Tom Lane <tgl@sss.pgh.pa.us> writes:

> ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
>> I just noticed that when contrib/seg was converted to V1 calling
>> convention (commit 389bb2818f4), the PG_GETARG_SEG_P() macro got defined
>> in terms of PG_GETARG_POINTER().  But it itself calls DatumGetPointer(),
>> so shouldn't it be using PG_GETARG_DATUM()?
>
> Yup, I agree.  Pushed.

Thanks!

>             regards, tom lane

- ilmari
-- 
"The surreality of the universe tends towards a maximum" -- Skud's Law
"Never formulate a law or axiom that you're not prepared to live with
 the consequences of."                              -- Skud's Meta-Law

pgsql-hackers by date:

Previous
From: Amit Khandekar
Date:
Subject: Re: Minimal logical decoding on standbys
Next
From: Jehan-Guillaume de Rorthais
Date:
Subject: Re: pg_waldump erroneously outputs newline for FPWs, and anotherminor bug