Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition
Date
Msg-id 20191104180144.k6sn3rpjuzi4yfxi@alap3.anarazel.de
Whole thread Raw
In response to Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition  (ilmari@ilmari.org (Dagfinn Ilmari Mannsåker))
List pgsql-hackers
Hi,

On 2019-11-04 11:30:23 +0000, Dagfinn Ilmari Mannsåker wrote:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
> 
> > ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> >> I just noticed that when contrib/seg was converted to V1 calling
> >> convention (commit 389bb2818f4), the PG_GETARG_SEG_P() macro got defined
> >> in terms of PG_GETARG_POINTER().  But it itself calls DatumGetPointer(),
> >> so shouldn't it be using PG_GETARG_DATUM()?
> >
> > Yup, I agree.  Pushed.
> 
> Thanks!

Thanks both of you.

- Andres



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [PATCH] Include triggers in EXPLAIN
Next
From: Andres Freund
Date:
Subject: Re: 64 bit transaction id