Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition
Date
Msg-id 5109.1572796710@sss.pgh.pa.us
Whole thread Raw
In response to [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition  (ilmari@ilmari.org (Dagfinn Ilmari Mannsåker))
Responses Re: [PATCH] contrib/seg: Fix PG_GETARG_SEG_P definition  (ilmari@ilmari.org (Dagfinn Ilmari Mannsåker))
List pgsql-hackers
Tree view 
ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> I just noticed that when contrib/seg was converted to V1 calling
> convention (commit 389bb2818f4), the PG_GETARG_SEG_P() macro got defined
> in terms of PG_GETARG_POINTER().  But it itself calls DatumGetPointer(),
> so shouldn't it be using PG_GETARG_DATUM()?

Yup, I agree.  Pushed.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Dent John
Date:
Subject: Re: The flinfo->fn_extra question, from me this time.
Next
From: Tom Lane
Date:
Subject: Re: updating unaccent.rules for Arabic letters