Re: pgsql: Add support for building GiST index by sorting. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject Re: pgsql: Add support for building GiST index by sorting.
Date
Msg-id d8727aed-4d04-7d8b-b595-a1a59acb66c8@iki.fi
Whole thread Raw
In response to Re: pgsql: Add support for building GiST index by sorting.  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-committers
On 17/09/2020 23:07, Peter Geoghegan wrote:
> On Thu, Sep 17, 2020 at 1:34 AM Heikki Linnakangas
> <heikki.linnakangas@iki.fi> wrote:
>> Add support for building GiST index by sorting.
> 
> You forgot to bump catversion, despite your best efforts.  :-)
> 
> You left this behind:
> 
> +/* FIXME: bump this before pushing! */
> 
> I have settled on a system for this: I write myself a reminder on a
> prominently placed post-it note, days in advance of commit. I rarely
> have to bump catversion (due to the kinds of things I work on), and
> iso t's just too easy to forget any other way.

D'oh! I think I'm going to write a git post-push hook for this. 
Apparently even a FIXME comment in the code is not enough of a reminder 
to me.

Thanks for fixing it, Tom.

- Heikki



pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Add support for building GiST index by sorting.
Next
From: Tom Lane
Date:
Subject: pgsql: Remove support for postfix (right-unary) operators.