Re: Postgres Win32 build broken? - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: Postgres Win32 build broken?
Date
Msg-id d7a772a0-6afc-12a8-83e9-b19275421512@dunslane.net
Whole thread Raw
In response to Re: Postgres Win32 build broken?  (Ranier Vilela <ranier.vf@gmail.com>)
List pgsql-hackers
On 9/1/21 8:01 PM, Ranier Vilela wrote:
> Em qua., 1 de set. de 2021 às 19:49, Andrew Dunstan
> <andrew@dunslane.net <mailto:andrew@dunslane.net>> escreveu:
>
>
>     On 9/1/21 4:00 PM, Andrew Dunstan wrote:
>     > On 8/31/21 9:52 PM, Michael Paquier wrote:
>     >> On Tue, Aug 31, 2021 at 07:49:40PM -0300, Ranier Vilela wrote:
>     >>> I'm not a perl specialist and it seems to me that the Win32
>     build is broken.
>     >>> The Win32 build is still important because of the 32-bit
>     clients still in
>     >>> use.
>     >>> I'm investigating the problem.
>     >> Being able to see the command you are using for build.pl
>     <http://build.pl>, your
>     >> buildenv.pl <http://buildenv.pl> and/or config.pl
>     <http://config.pl>, as well as your build dependencies
>     >> should help to know what's wrong.
>     >>
>     >> MSVC builds are tested by various buildfarm members on a daily
>     basis,
>     >> and nothing is red.  I also have a x86 and x64 configuration with
>     >> VS2015 that prove to work as of HEAD at de1d4fe, FWIW.  Now, by
>     >> experience, one could say that N Windows PG developpers finish
>     with at
>     >> least (N+1) different environments.  Basically Simon Riggs's
>     theorem
>     >> applied to Windows development..
>     >
>     >
>     > I am seeing the same result as Ranier using VS2017 and VS 2019.
>     >
>     >
>
>     But not with VS2013. If you need to build 32 bit client libraries,
>     using
>     an older VS release is probably your best bet.
>
> Thanks Andrew, but I finally got a workaround for the problem.
> set MSBFLAGS=/p:Platform="Win32"
>
> Now Postgres builds fine in 32 bits with the latest msvc (2019).
> Is it worth documenting this?
>
>


I think we should be able to detect this and do it automatically in
src/tools/msvc/build.pl, or possibly in the project files.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com




pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Added schema level support for publication.
Next
From: "houzj.fnst@fujitsu.com"
Date:
Subject: Fix typo in comments