pg_dump test: Make concatenated create_sql commands more readable - Mailing list pgsql-hackers

From Peter Eisentraut
Subject pg_dump test: Make concatenated create_sql commands more readable
Date
Msg-id d6aec95a-8729-43cc-2578-f2a5e46640e0@enterprisedb.com
Whole thread Raw
List pgsql-hackers
When the pg_dump 002_pg_dump.pl test generates the command to load the 
schema, it does

     # Add terminating semicolon
     $create_sql{$test_db} .= $tests{$test}->{create_sql} . ";";

In some cases, this creates a duplicate semicolon, but more importantly, 
this doesn't add any newline.  So if you look at the result in either 
the server log or in tmp_check/log/regress_log_002_pg_dump, it looks 
like a complete mess.  The attached patch makes the output look cleaner 
for manual inspection: add semicolon only if necessary, and add two 
newlines.
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Avoid memory leaks during base backups
Next
From: Amit Kapila
Date:
Subject: Re: Logical WAL sender unresponsive during decoding commit