Re: [HACKERS] Transaction control in procedures - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [HACKERS] Transaction control in procedures
Date
Msg-id d60560be-f6a6-ba8b-2ee2-7a7bc7d4666b@2ndquadrant.com
Whole thread Raw
In response to Re: [HACKERS] Transaction control in procedures  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: [HACKERS] Transaction control in procedures
List pgsql-hackers
On 1/15/18 12:57, Andrew Dunstan wrote:
> This confused me slightly:
> 
>     +    Transactions cannot be ended inside loops through query results
>     or inside
>     +    blocks with exception handlers.
> 
> I suggest: "A transaction cannot be ended inside a loop over query
> results, nor inside a block with exception handlers."

fixed

> The patch has bitrotted slightly in src/backend/commands/portalcmds.c

merged

> The plperl expected file needs updating. Also, why does spi_commit() in
> a loop result in an error message but not spi_rollback()?

This is all changed now after the patch for portal pinning in PL/Perl
and PL/Python has been committed.  The attached patch behaves better.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] Proposal: Local indexes for partitioned table
Next
From: Adam Brightwell
Date:
Subject: Re: PATCH: Exclude unlogged tables from base backups