On 2019-07-13 19:20, Fabien COELHO wrote:
> The second error message about conflicting option could more explicit than
> a terse "conflicting or redundant options"? The user may expect later
> options to superseedes earlier options, for instance.
done
> About the pg_dump code, I'm wondering whether it is worth generating
> LOCALE as it breaks backward compatibility (eg dumping a new db to load it
> into a older version).
We don't really care about backward compatibility here. Moving forward,
with ICU and such, we don't want to have to drag around old syntax forever.
> If it is to be generated, I'd do merge the two conditions instead of
> nesting.
>
> if (strlen(collate) > 0 && strcmp(collate, ctype) == 0)
> // generate LOCALE
done
How about this patch?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
