Extra quote_all_identifiers in _dumpOptions - Mailing list pgsql-hackers

From Arthur Zakirov
Subject Extra quote_all_identifiers in _dumpOptions
Date
Msg-id d3d92ce9-78a4-8adb-0393-d3deeec29f7e@postgrespro.ru
Whole thread Raw
Responses Re: Extra quote_all_identifiers in _dumpOptions
List pgsql-hackers
Hello hackers,

While working on pg_dump I noticed the extra quote_all_identifiers in 
_dumpOptions struct. I attached the patch.

It came from refactoring by 0eea8047bf. There is also a discussion:
https://www.postgresql.org/message-id/CACw0%2B13ZUcXbj9GKJNGZTkym1SXhwRu28nxHoJMoX5Qwmbg_%2Bw%40mail.gmail.com

Initially the patch proposed to use quote_all_identifiers of 
_dumpOptions. But then everyone came to a decision to use global 
quote_all_identifiers from string_utils.c, because fmtId() uses it.

-- 
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Attachment

pgsql-hackers by date:

Previous
From: Surafel Temesgen
Date:
Subject: Re: FETCH FIRST clause PERCENT option
Next
From: Darafei "Komяpa" Praliaskouski
Date:
Subject: Re: GiST "choose subtree" support function to inline penalty