Re: CREATE TABLE LIKE INCLUDING INDEXES support - Mailing list pgsql-patches

From NikhilS
Subject Re: CREATE TABLE LIKE INCLUDING INDEXES support
Date
Msg-id d3c4af540707160158r7069b30cs52da5f002a2ff673@mail.gmail.com
Whole thread Raw
In response to Re: CREATE TABLE LIKE INCLUDING INDEXES support  (Neil Conway <neilc@samurai.com>)
Responses Re: CREATE TABLE LIKE INCLUDING INDEXES support
List pgsql-patches
Hi,

> Attached is a revised patch that does that. Barring any objections, I'll
> apply this to HEAD tomorrow.
>

A minor correction below in your patch:

--- src/include/commands/defrem.h    16 Jul 2007 05:19:43 -0000
*************** extern void DefineIndex(RangeVar *heapRe
*** 26,31 ****
--- 26,32 ----
              List *options,
+             char *inhreloptions,

Guess you want to use "src_options" here to be uniform with usages
elsewhere that you have replaced. You suppose "src_options" is much
more readable than "inhreloptions" or "inh_idxoptions"? Your call :).

Regards,
Nikhils
--
EnterpriseDB               http://www.enterprisedb.com

pgsql-patches by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [BUGS] BUG #3439: pg_standby and path name with space
Next
From: "Affan Salman"
Date:
Subject: Re: Deferred RI trigger for non-key UPDATEs and subxacts