Re: CREATE TABLE LIKE INCLUDING INDEXES support - Mailing list pgsql-patches

From NikhilS
Subject Re: CREATE TABLE LIKE INCLUDING INDEXES support
Date
Msg-id d3c4af540704122251i7997cbb4h75d33e5ef8303376@mail.gmail.com
Whole thread Raw
In response to Re: CREATE TABLE LIKE INCLUDING INDEXES support  (Trevor Hardcastle <chizu@spicious.com>)
Responses Re: CREATE TABLE LIKE INCLUDING INDEXES support
List pgsql-patches
Hi Trevor,


+
+                                       parent_index_info = BuildIndexInfo(parent_index);

The above is not used anywhere else in the code and seems redundant.

+
+                                       ereport(NOTICE,
+                                                       (errmsg("Index \"%s\" cloned.",
+                                                                       RelationGetRelationName(parent_index))));

DefineIndex will give out a message anyways for unique/primary keys. The above seems additional to it.

Regards,
Nikhils

--
EnterpriseDB               http://www.enterprisedb.com

pgsql-patches by date:

Previous
From: Koichi Suzuki
Date:
Subject: Re: [HACKERS] Full page writes improvement, code update
Next
From: "Pavan Deolasee"
Date:
Subject: Re: Dead Space Map version 3 (simplified)