Re: New features for pgbench - Mailing list pgsql-patches

From NikhilS
Subject Re: New features for pgbench
Date
Msg-id d3c4af540702112247o771a2b6fud17ce8d9399b529f@mail.gmail.com
Whole thread Raw
In response to New features for pgbench  (Greg Smith <gsmith@gregsmith.com>)
Responses Re: New features for pgbench
List pgsql-patches
Hi,

On 2/12/07, Greg Smith <gsmith@gregsmith.com> wrote:
The attached adds two new command line switches to pgbench:

-x:  Generate extended detail in the latency log, including a timestamp
for each transaction

From your patch I see that it augments the -l flag. IMHO it does not make sense to add another flag. We can save the "if" check and log the extended contents as part of -l itself.

-X:  Do extra cleanup after the run (vacuum on all tables, checkpoint)
before stopping the clock.  This gives substantially more consistancy in
results between runs.  

I am sorry, but I do not understand the above. If I read it correctly, are you suggesting that the same database with a prior pgbench run be used for further pgbench runs? How is it useful? How can one guarantee consistency of observed tps values with this in place?

Regards,
Nikhils


--
EnterpriseDB               http://www.enterprisedb.com

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: New features for pgbench
Next
From: Greg Smith
Date:
Subject: Re: New features for pgbench