On 29.11.24 21:57, Kirill Gavrilov wrote:
> Same thing applies to log_parameter_max_length, for example.
>
> postgres=# set log_parameter_max_length = '1foo';
> ERROR: invalid value for parameter "log_parameter_max_length": "1foo"
> HINT: Valid units for this parameter are "B", "kB", "MB", "GB", and "TB".
> postgres=# set log_parameter_max_length = '1TB';
> ERROR: invalid value for parameter "log_parameter_max_length": "1TB"
> HINT: Value exceeds integer range.
>
> I think we can leave it as is.
I see. So I guess it is out of scope to change this message here.
Small nitpicks:
1) The indentation of the comment at postgresql.conf.sample is a little
bit off
#max_log_size = 0 # max size of logged statement
# 0 disables the feature
IMHO it looks better like this:
#max_log_size = 0 # max size of logged statement
# 0 disables the feature
2) You introduced a trailing whitespace at L34 (Not critical :))
+ Zero disables the setting.
It happens to me all the time, so I usually try to apply my patches in a
clean branch just to make sure I didn't miss anything.
Other than that, I have nothing more to add at this point.
Thanks
--
Jim
