Re: PATCH: Exclude additional directories in pg_basebackup - Mailing list pgsql-hackers

On 9/26/16 2:36 AM, Michael Paquier wrote:

> Just a nit:
>          <para>
> -         <filename>postmaster.pid</>
> +         <filename>postmaster.pid</> and <filename>postmaster.opts</>
>          </para>
> Having one <para> block for each file would be better.

OK, changed.

> +const char *excludeFile[] =
> excludeFiles[]?
>
> +# Move pg_replslot out of $pgdata and create a symlink to it
> +rename("$pgdata/pg_replslot", "$tempdir/pg_replslot")
> +   or die "unable to move $pgdata/pg_replslot";
> +symlink("$tempdir/pg_replslot", "$pgdata/pg_replslot");
> This will blow up on Windows. Those tests need to be included in the
> SKIP block. Even if your code needs to support junction points on
> Windows, as perl does not offer an equivalent for it we just cannot
> test it on this platform.

Fixed.

--
-David
david@pgmasters.net